Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

192 caching of views needed #213

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

bufordrat
Copy link
Collaborator

Fixes #.

Changes in this request

@bufordrat
Copy link
Collaborator Author

I added the @cache_page decorator to the collections, spaces, and staff directory views, but it doesn't seem to have an effect. I think these views may already be getting cached. See, for example, the following language, which suggests that the @cache_page decorator is for when you want to cherry pick which views get cached, rather than just caching everything you possibly can:

"The wagtail-cache middleware will attempt to cache ALL responses that appear to be cacheable...
...To only cache specific views, remove the middleware and use the cache_page decorator on views or URLs."

From:
https://docs.coderedcorp.com/wagtail-cache/stable/getting_started/install.html

@bufordrat bufordrat requested a review from bbusenius November 4, 2019 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant