Fix a few issues with EmojiCompat
#579
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhoran
approved these changes
Mar 9, 2024
We used to try emojifying regardless of EmojiCompat load state. This was not a big issue, as `EmojiCompat` usually loads fast enough. However, on some systems loading dynamic fonts is not available, which resulted in errors printed for every emojification attempt, i. e. for every single line. This change makes emojifications occur only when `EmojiCompat` is fully initialized and loaded. Also, initialization status is printed to logcat. Closes #561
By default, `EmojiCompat` only adds emoji glyphs for those emojis that are currently missing in the platform, which results in mismatched emoji styles. This change makes all emojis appear in modern style.
oakkitten
force-pushed
the
fix-emojicompat
branch
from
cc88820 to
810622b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #561 and individual commit messages