Target API 34

[oakkitten]

This isn't very big but it requires a bit of testing once it's done. Might decide to not merge it as is but consolidate with other branches first since they also contain library updates.

The important thing to look at here is the stuff in Notificator.kt and the strings. If you can, please update without uninstalling/wiping data and see if it works well. Particularly, you shouldn't be stuck in any sorts of permission request loops. Also, if the app shows a dialog explaining why we need a permission, tapping on “Grant permission” should show the permission dialog.

Note that the exact alarm permission is NOT reset with app data, but IS reset with app uninstall & reinstall. Unlike notifications permission.

[zopieux]

There is this law on Android, I've coined it the Red Tape Phenomenon: for any large enough Android app, permission handling code tends toward being 100% of the logic.

What a nightmare.

I haven't tested this yet, ask me again in 2 weeks, I don't have access to a good computer.

[zopieux]

😅

[mhoran]

What's this about?

[oakkitten]

Uhh not really sure, did that commit a while back

I'm assuming that connect() was called too often but this wasn't a problem since if we were connected it was no-op. Now that it checks for permissions and stuff it was easier to fix the too much part than reworking the logic otherwise?

Can't be sure tho

[oakkitten]

As this was okayed, it can be merged along with other things, but we are going to need a few strings first. Also, if anyone has any suggestions regarding the wording, or any other comments about the messages, feel free to post them here on in the channel.

What needs to be translated:

<string name="error__etc__cannot_navigate_input_history_if_sharespans_in_input">
    Remove or upload media to navigate input history</string>

<string name="dialog__alarm_permission_for_ping__title">
    Permission required</string>
<string name="dialog__alarm_permission_for_ping__text">
    Pinging machinery needs the permission to set exact alarms.
    Alternatively, you can disable pinging in connection settings.</string>
<string name="dialog__alarm_permission_for_ping__positive_button">Grant permission</string>

<string name="dialog__notification_permission__title">Permission wanted</string>
<string name="dialog__notification_permission__text">
    To show notifications, we need a permission.
    This is optional.
    If you don’t enable notifications now, you can always enable them later in the settings.
    \n
    \nWhen connected, a persistent notification is shown.
    To hide it from the status bar,
    we suggest that you set the “Connection status” notification category to “Silent”.
    \n
    \nYou can also customize notifications for individual buffers, changing sound, vibration, etc.
    These settings will appear in “Notification categories” → “Conversations”
    when you have received at least one notification for the corresponding buffer.
</string>
<string name="dialog__notification_permission__positive_button">Grant permission</string>
<string name="dialog__notification_permission_not_granted__negative_button">Continue without granting permission</string>

Pinging @zopieux and @weechatter for help

[zopieux]

Demande d'autorisation

[zopieux]

Le mécanisme de 'pings' a besoin de l'autorisation de programmer des alarmes exactes. Si vous préférez, vous pouvez désactiver les 'pings' dans les paramètres de connexion.

[zopieux]

Donner l'autorisation

[zopieux]

Demande d'autorisation

(unclear why it's a different wording that the one for alarms)

[oakkitten]

It's not required, can continue without permission

[zopieux]

I see. The French wording is neutral enough to be used in both.

[zopieux]

Pour pouvoir afficher des notifications, Weechat Android a besoin d'une autorisation optionnelle. Vous pouvez refuser maintenant et réactiver les notifications à tout moment en allant dans les paramètres.

Une notification restera affichée aussi longtemps que la connexion perdure. Si cela vous opportune, vous pouvez rendre silencieuse ou cacher cette notification via les options de la catégorie « État de la connexion ».

Vous pouvez aussi changer individuellement les options de notification de chaque tampon. Pour cela vous devez recevoir au moins une notification pour ce tampon, après quoi les options seront disponibles dans « Catégories de notifications » → « Conversations ».

[zopieux]

Donner l'autorisation

[zopieux]

Continuer sans donner l'autorisation

[weechatter]

<string name="error__etc__cannot_navigate_input_history_if_sharespans_in_input">
    Entfernen oder laden Sie Medien hoch, um durch den Eingabeverlauf zu navigieren</string>

<string name="dialog__alarm_permission_for_ping__title">
    Erlaubnis erforderlich</string>
<string name="dialog__alarm_permission_for_ping__text">
    Maschine pingen, benötigt die Erlaubnis, genaue Alarme zu setzen.
    Alternativ können man den Ping in den Verbindungseinstellungen deaktivieren.</string>
<string name="dialog__alarm_permission_for_ping__positive_button">Erlaubnis erteilen</string>

<string name="dialog__notification_permission__title">Erlaubnis erwünscht</string>
<string name="dialog__notification_permission__text">
    Um Benachrichtigungen anzuzeigen, benötigen wir eine Erlaubnis.
    Dies ist optional.
    Wenn Sie Benachrichtigungen jetzt nicht aktivieren, können Sie diese jederzeit nachträglich in den Einstellungen aktivieren.
    \n
    \nWenn eine Verbindung besteht, wird eine dauerhafte Benachrichtigung angezeigt.
    Um es aus der Statusleiste auszublenden,
    empfehlen wir die Benachrichtigungskategorie „Verbindungsstatus“ auf „Stumm“ zu setzen.
    \n
    \nSie können Benachrichtigungen, z.B. veränderter Ton, Vibration usw., auch für einzelne Buffer anpassen.
    Diese Einstellungen werden unter „Benachrichtigungskategorien“ → „Konversationen“ angezeigt,
    wenn Sie mindestens eine Benachrichtigung für den entsprechenden Buffer erhalten haben.
</string>
<string name="dialog__notification_permission__positive_button">Erlaubnis erteilen</string>
<string name="dialog__notification_permission_not_granted__negative_button">Fortfahren, ohne Erlaubnis zu erteilen</string>

[oakkitten]

note to self, thanks @PeGaSuS-Coder

Supprimez ou envoyez les fichiers pour parcourir l'historique des entrées

[oakkitten]

I'm sorry but I took a second look at how things work in the emulator and I think we need to change a few strings. Namely, instead of

To hide it from the status bar, we suggest that you set the “Connection status” notification category to “Silent”.

we should say

To hide it from the status bar, we suggest that you enable notification minimization for the category “Connection status”.

and instead of

You can also customize notifications for individual buffers, changing sound, vibration, etc. These settings will appear in “Notification categories” → “Conversations” when you have received at least one notification for the corresponding buffer.

we should say

You can also customize notifications for individual buffers, changing sound, vibration, etc. To do this, when you have received at least one notification for the corresponding buffer, long tap it and go to settings.

Note on actual behavior. When the app is installed (on 14), it seems that the category of the connection status starts with Silent, which is the prerequisite for the minimization option to appear. Don't think it worth mentioning Silent at all, unless in some cases the app does not default to that.

As for the Conversations, on my Samsung I can't customize them at all since they just don't appear for some reason unless I bubble a conversation. A bug with Samsung? On the emulator, the conversation does not appear in the list unless I long tap the notification; apparently long-tapping is enough, no need to change any settings, but if I don't do it I don't see it in the list.

Tagging @zopieux and @weechatter again

[weechatter]

<string name="error__etc__cannot_navigate_input_history_if_sharespans_in_input">
    Entfernen oder laden Sie Medien hoch, um durch den Eingabeverlauf zu navigieren</string>

<string name="dialog__alarm_permission_for_ping__title">
    Erlaubnis erforderlich</string>
<string name="dialog__alarm_permission_for_ping__text">
    Maschine pingen, benötigt die Erlaubnis, genaue Alarme zu setzen.
    Alternativ können man den Ping in den Verbindungseinstellungen deaktivieren.</string>
<string name="dialog__alarm_permission_for_ping__positive_button">Erlaubnis erteilen</string>

<string name="dialog__notification_permission__title">Erlaubnis erwünscht</string>
<string name="dialog__notification_permission__text">
    Um Benachrichtigungen anzuzeigen, benötigen wir eine Erlaubnis.
    Dies ist optional.
    Wenn Sie Benachrichtigungen jetzt nicht aktivieren, können Sie diese jederzeit nachträglich in den Einstellungen aktivieren.
    \n
    \nWenn eine Verbindung besteht, wird eine dauerhafte Benachrichtigung angezeigt.
    Um es aus der Statusleiste auszublenden,
    wird empfohlen, die Benachrichtigungsminimierung für die Kategorie „Verbindungsstatus“ zu aktivieren.
    \n
    \nEs können Benachrichtigungen, z.B. Ton, Vibration usw. auch für einzelne Buffer angepasst werden.
    Wenn mindestens eine Benachrichtigung für den entsprechenden Buffer erhalten wurde, muss man lange auf die Benachrichtigung tippen,
    um zu den Einstellungen zu gelangen.
</string>
<string name="dialog__notification_permission__positive_button">Erlaubnis erteilen</string>
<string name="dialog__notification_permission_not_granted__negative_button">Fortfahren, ohne Erlaubnis zu erteilen</string>

[TehPeGaSuS]

To hide it from the status bar, we suggest that you enable notification minimization for the category “Connection status”.

Pour le masquer de la barre d'état, nous vous suggérons d'activer l'option de réduire les notifications pour la catégorie « État de la connexion ».

You can also customize notifications for individual buffers, changing sound, vibration, etc. To do this, when you have received at least one notification for the corresponding buffer, long tap it and go to settings.

Vous pouvez également personnaliser les notifications pour des tampons individuels, modifier le son, les vibrations, etc. Pour le faire, lorsque vous avez reçu au moins une notification pour le tampon correspondant, appuyez longuement dessus et accédez aux paramètres.