Refactor CLI flags to support explicit disable options #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed existing CLI flags for password generation to `no_xxx` format to allow explicit disabling of character types. The transition includes changing `--uppercase` to `--no-uppercase` with its default set to false, similarly for `--lowercase`, `--number`, and `--symbol`. This modification addresses a significant limitation of the previous approach: if the default were set to false, users would need to specify each option to enable it; if set to true, it would be impossible to disable them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed existing CLI flags for password generation to
no_xxxformat to allow explicit disabling of character types. The transition includes changing--uppercaseto--no-uppercasewith its default set to false, similarly for--lowercase,--number, and--symbol.This modification addresses a significant limitation of the previous approach:
false, users would need to specify each option to enable it;true, it would be impossible to disable them.