Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix resolve_error_handler return type #2392

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Fix resolve_error_handler return type #2392

merged 1 commit into from
Oct 4, 2024

Conversation

ljodal
Copy link
Contributor

@ljodal ljodal commented Oct 4, 2024 •
edited
Loading

URLResolver.resolve_error_handler should return a callable that takes in a request and returns a response, with no addition arguments.

@ljodal
Update resolvers.pyi
187bc4b 
Resolver.resolve_error_handler should return a callable that takes in a request and returns a response, with no addition arguments.
sobolevn
sobolevn approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sobolevn sobolevn merged commit b1f690b into typeddjango:master Oct 4, 2024
38 checks passed
@ljodal ljodal deleted the fix-resolve-error-handler branch October 4, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ljodal @sobolevn