Update _Choices type alias #2368
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
reviewed
Sep 11, 2024
joaoseckler
force-pushed
the
django5-choices
branch
4 times, most recently
from
4a6dc8e to
a162237
Compare
|
@sobolevn, thanks for the obvious feedback. I've reduced the scope of the PR to change only the |
joaoseckler
force-pushed
the
django5-choices
branch
2 times, most recently
from
9f5ef89 to
46b8648
Compare
|
Hey, sorry for the amount of force-pushes and failed tests. I must have gotten something wrong with my environment, because the test suite was passing locally since the beginning, even though the errors are quite simple |
Django 5 allows model field choices to be callables, mappings or subclasses of models.Choices. This commit introduces these options in the stubs.
joaoseckler
force-pushed
the
django5-choices
branch
from
46b8648 to
8e79ee2
Compare
|
Please, fix the merge conflict :) |
|
I pushed an updated version here which should be ready with the merge conflict resolved: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the _Choices type alias
Django 5 allows model field choices to be callables, mappings or subclasses of
models.Choices. This PR introduces these options in the stubs.Related issues
No related issues