Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add in dotnet 9 fix for codeql build #274

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

wmundev
Copy link
Collaborator

@wmundev wmundev commented Nov 16, 2024

https://github.com/twcclegg/libphonenumber-csharp/actions/runs/11840336347/job/32993909242 is failing because no dotnet 9 is available on that github action

Changes

  • add in dotnet 9 fix for codeql build

@wmundev wmundev self-assigned this Nov 16, 2024
Copy link

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.27%. Comparing base (7847c6f) to head (14745f5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #274   +/-   ##
=======================================
  Coverage   75.27%   75.27%           
=======================================
  Files          34       34           
  Lines        4424     4424           
  Branches     1001     1001           
=======================================
  Hits         3330     3330           
  Misses        885      885           
  Partials      209      209           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wmundev wmundev requested a review from twcclegg November 16, 2024 03:11
@wmundev wmundev merged commit 24ea3ab into twcclegg:main Nov 17, 2024
6 checks passed
@wmundev wmundev deleted the feature/fix-codeql branch November 17, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants