-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add fallback to wget for installation script #29
base: main
Are you sure you want to change the base?
Conversation
Undo the formatting changes please |
Is it really necessary to check for 'wget' in Windows? |
Ah, Prettier sucks 😅 |
Hey @Gregory-K 👋🏻 , You're correct that modern versions of Windows (since Windows 10 version 1803) and macOS come with curl pre-installed. Therefore, it is generally not necessary to check for wget on these platforms if you are confident that your script will only be run on such systems but it's good for some other versions of Windows or macOS where any of them are not available. WDYT @tusharsadhwani 👀 |
@Mr-Sunglasses, yes, I thought of the niche cases, but I'm not so sure (haven't checked) that modern python binary distributions support such old systems (python 3.9 dropped Win 7 support), and whether 'yen' intelligently provides custom builds for those OSs (an example). Anyway, I'm not against 'wget' on windows, I'm just raising a concern on whether the if statement will ever return true in a meaningful way... |
can confirm 3.9 and above won't run on windows 7. similarly 3.5 and above won't run on xp. i think it's fine to keep the wget code regardless, just in case someone decided to delete curl from their system. |
fix: #19