Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add fallback to wget for installation script #29

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Mr-Sunglasses
Copy link

fix: #19

  • Updated the bootstrapping script to use wget when curl is not available.
  • A helpful error message if neither curl nor wget is installed.

@tusharsadhwani
Copy link
Owner

Undo the formatting changes please

@Gregory-K
Copy link
Contributor

Is it really necessary to check for 'wget' in Windows?
Windows 10 comes with the curl tool bundled (since version 1804), and I think the same applies to macOS.

@Mr-Sunglasses
Copy link
Author

Undo the formatting changes please

Ah, Prettier sucks 😅

@Mr-Sunglasses
Copy link
Author

Is it really necessary to check for 'wget' in Windows? Windows 10 comes with the curl tool bundled (since version 1804), and I think the same applies to macOS.

Hey @Gregory-K 👋🏻 , You're correct that modern versions of Windows (since Windows 10 version 1803) and macOS come with curl pre-installed. Therefore, it is generally not necessary to check for wget on these platforms if you are confident that your script will only be run on such systems but it's good for some other versions of Windows or macOS where any of them are not available.

WDYT @tusharsadhwani 👀

@Gregory-K
Copy link
Contributor

@Mr-Sunglasses, yes, I thought of the niche cases, but I'm not so sure (haven't checked) that modern python binary distributions support such old systems (python 3.9 dropped Win 7 support), and whether 'yen' intelligently provides custom builds for those OSs (an example).

Anyway, I'm not against 'wget' on windows, I'm just raising a concern on whether the if statement will ever return true in a meaningful way...

@tusharsadhwani
Copy link
Owner

can confirm 3.9 and above won't run on windows 7. similarly 3.5 and above won't run on xp.

i think it's fine to keep the wget code regardless, just in case someone decided to delete curl from their system.

install.bat Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make curl optional for installing yen
3 participants