Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test cases for exploring and configuring importers #13

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ikanias
Copy link

@ikanias ikanias commented Jan 16, 2025

No description provided.

Copy link
Contributor

@mrrajan mrrajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ikanias I have reviewed the Scenario's and it looks fine. But there are some changes needed on the syntax level.

  • Leveraging "Background" keyword for before test action with "Given" statement
  • Removing "#" before the scenario's.
  • Most of the "Then" statement were written in future actions like "will be displayed", "will be greyed out". I request to change it into expected state or behavior with "should be" like "should be displayed", "should greyed out", "should be visible", "should be disable"

I have added couple suggestion for the above changes. Please review and let me know WDYT.

Comment on lines +1 to +2
Feature: Importer Explorer - View and configure importers on importers details page
Background: As a Devsecops I want to view and configure all of the Importers currently configured including default Importers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition background are similar to "BeforeTest" it would be executed for all the scenarios under feature file. We can have the Given statements into this.

Suggested change
Feature: Importer Explorer - View and configure importers on importers details page
Background: As a Devsecops I want to view and configure all of the Importers currently configured including default Importers
Feature: Importer Explorer - View and configure importers on importers details page
Background:
Given the user navigates to and logs into the TPA application

Comment on lines +4 to +8
#Scenario: The user can display importers page with all relevant field names
Given TPA 2.0 is installed successfully
When the user selects the importers menu option
Then importers page is displayed showing the fields Name, Type, Description, Source, Period and Status in a table
And there will be 3 dots (Hamburger icon) displayed for each importer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#Scenario: The user can display importers page with all relevant field names
Given TPA 2.0 is installed successfully
When the user selects the importers menu option
Then importers page is displayed showing the fields Name, Type, Description, Source, Period and Status in a table
And there will be 3 dots (Hamburger icon) displayed for each importer
Scenario: User navigates to Importer Explore page
When the user selects the importers from left navigation menu option
Then Application navigates to Importers page
And The column headers Name, Type, Description, Source, Period and Status should be visible
And Call to Action button for each importer should be visible

Comment on lines +10 to +15
#Scenario: The user can check pagination controls on importers page
Given TPA 2.0 is installed successfully
When the user selects the importers menu option
Then the importers page will be displayed with pagination controls with correct values
And it will be possible to move between pages accordingly
And it will be possible to add page numbers in the pagination text box and pressing Enter to move to the desired page
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have generic pagination scenario and scripts to verify pagination for all pages on the application

Suggested change
#Scenario: The user can check pagination controls on importers page
Given TPA 2.0 is installed successfully
When the user selects the importers menu option
Then the importers page will be displayed with pagination controls with correct values
And it will be possible to move between pages accordingly
And it will be possible to add page numbers in the pagination text box and pressing Enter to move to the desired page
Scenario: Pagination controls on importer explorer page
When The user is on Importer Explorer page
Then the importers page will be displayed with pagination controls with correct values
And it will be possible to move between pages accordingly
And it will be possible to add page numbers in the pagination text box and pressing Enter to move to the desired page


#Scenario: The user can expand an importer to see its logs
Given the importers option is selected on the left menu
When the user clicks on an importer row ‘>’ icon
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When the user clicks on an importer row ‘>’ icon
When the user expands importer row

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants