Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test plans for Advisory and Vulnerability explorers. #11

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

vobratil
Copy link

No description provided.

@vobratil
Copy link
Author

After Pavel's feedback, I've updated the MR with a better use of the keywords as they are defined in the docs.

Copy link
Contributor

@mrrajan mrrajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look and let me know WDYT?

tests/features/advisory-explorer.feature Outdated Show resolved Hide resolved
tests/features/advisory-explorer.feature Show resolved Hide resolved
tests/features/advisory-explorer.feature Outdated Show resolved Hide resolved
tests/features/advisory-explorer.feature Outdated Show resolved Hide resolved
When User navigates to the Vulnerabilities Explorer page
Then The ID and Title of each vulnerability is visible on each row
And "Show more" button is visible for vulnerabilities with a long title
And Advisory metadata (CVSS, Date published, Related documents) is visible on each row
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be updated Vulnerability metadata CVE name, CVSS score and CVE description

tests/features/vulnerability-explorer.feature Outdated Show resolved Hide resolved
tests/features/vulnerability-explorer.feature Outdated Show resolved Hide resolved
tests/features/vulnerability-explorer.feature Show resolved Hide resolved
tests/features/vulnerability-explorer.feature Outdated Show resolved Hide resolved
tests/features/vulnerability-explorer.feature Outdated Show resolved Hide resolved
@vobratil
Copy link
Author

@mrrajan I was a bit confused about what the difference between an overview and an explorer was. Now it's clear. Thanks for the suggestions, I've made the changes.

Copy link
Contributor

@mrrajan mrrajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed the unresolved conversations. Revoking my approval.

@vobratil vobratil force-pushed the advisory-vulnerability-testcases branch from d664a61 to a7cae26 Compare January 17, 2025 13:02
@vobratil
Copy link
Author

@mrrajan Okay, fixed the last remaining things that you pointed out.

Co-authored-by: Rajan Ravi <86094767+mrrajan@users.noreply.github.com>
Copy link
Contributor

@mrrajan mrrajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants