Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix query runners failing to expose local ports #24677

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

hashhar
Copy link
Member

@hashhar hashhar commented Jan 10, 2025

The logic was mistakenly inverted in
a99d96e.

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

The logic was mistakenly inverted in
a99d96e.
Copy link
Contributor

@krvikash krvikash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hashhar for fixing this.

@hashhar
Copy link
Member Author

hashhar commented Jan 10, 2025


Upload test results: plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergLocalConcurrentWrites.java#L350
For query 20250110_085734_00475_jte24: 
 SELECT * FROM test_concurrent_truncate_and_inserts_table_6z6vgi51dd
not equal
Actual rows (up to 100 of 0 extra rows shown, 0 rows in total):
    
Expected rows (up to 100 of 2 missing rows shown, 2 rows in total):
    [21, 30]
    [31, 40]

is flaky failure. Merging.

@hashhar hashhar merged commit 218f3ed into trinodb:master Jan 10, 2025
91 of 92 checks passed
@github-actions github-actions bot added this to the 469 milestone Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants