Always fire QueryCompletedEvent for DDL queries #24651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasz-stec
force-pushed
the
ls/2501/02-ddl-completed-event
branch
from
c9ee13b to
3fe314c
Compare
It is needed to test the query execution without reading the final query info which triggers the QueryCompletedEvent
lukasz-stec
force-pushed
the
ls/2501/02-ddl-completed-event
branch
from
3fe314c to
644161f
Compare
|
Well, there's #24354 too :) |
Yeah, I mentioned this in the description. This is a slightly refactored version. We can go with your PR too if you want., |
Oh, you did indeed. I guess I only read the first section. (But the code did look familiar!) |
ksobolew
reviewed
Jan 9, 2025
| try (StandaloneQueryRunner queryRunner = new StandaloneQueryRunner(testSession())) { | ||
| queryRunner.installPlugin(new MemoryPlugin()); | ||
| queryRunner.createCatalog("memory", "memory"); | ||
| Set<String> queryCompletedQueryIds = new HashSet<>(); |
There was a problem hiding this comment.
Should this be synchronized somehow?
There was a problem hiding this comment.
I think it should. Good catch.
lukasz-stec
force-pushed
the
ls/2501/02-ddl-completed-event
branch
from
644161f to
973ea75
Compare
Previously the event was fired because client protocol is reading the final query info. That is brittle and theoretically could be removed making DDL queries fail to trigger query completed event.
lukasz-stec
force-pushed
the
ls/2501/02-ddl-completed-event
branch
from
973ea75 to
95f4b16
Compare
wendigo
approved these changes
Jan 9, 2025
hashhar
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously the event was fired because client protocol
is reading the final query info. That is brittle and theoretically
could be removed making DDL queries fail to trigger query completed event.
Additional context and related issues
A slightly changed version of #24354
Release notes
( X) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: