Support generating sequences in the Faker connector #24590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nineinchnick
force-pushed
the
faker-sequences
branch
2 times, most recently
from
0bb9e43 to
021867e
Compare
losipiuk
reviewed
Dec 30, 2024
plugin/trino-faker/src/main/java/io/trino/plugin/faker/FakerPageSource.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Dec 30, 2024
plugin/trino-faker/src/main/java/io/trino/plugin/faker/FakerPageSource.java
Show resolved
Hide resolved
losipiuk
reviewed
Dec 30, 2024
| { | ||
| Range genericRange = handle.domain().getValues().getRanges().getSpan(); | ||
| Type type = handle.type(); | ||
| // check every type in order defined in StandardTypes |
There was a problem hiding this comment.
Only for consistency, there are now 3 blocks of code that enumerate different types. I also wanted to document why they're in this particular order.
losipiuk
reviewed
Dec 30, 2024
plugin/trino-faker/src/main/java/io/trino/plugin/faker/FakerPageSource.java
Outdated
Show resolved
Hide resolved
Fix handling upper bounds for floating point types. The implementation did not account for rounding issue near the bound, and the test was using values outside of the allowed range.
Refactor to make subsequent commit's diff smaller
nineinchnick
force-pushed
the
faker-sequences
branch
from
021867e to
f7d560f
Compare
plugin/trino-faker/src/main/java/io/trino/plugin/faker/FakerColumnHandle.java
Show resolved
Hide resolved
nineinchnick
force-pushed
the
faker-sequences
branch
from
f7d560f to
a6137e3
Compare
raunaqmorarka
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support generating sequences in the Faker connector. It might be useful for columns representing primary keys, which often use sequences. Another use case would be equal distribution of values in temporal columns.
There's also no other easy way of generating sequences for timestamps, since the
sequencefunction has a limit of 10k elements, and thesequencetable function doesn't support temporal types at all.It's a prerequisite for #24585
There are a few limitations:
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: