Add cosine_distance for sparse vectors #24027
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosabua
commented
Nov 4, 2024
core/trino-main/src/test/java/io/trino/operator/scalar/TestMathFunctions.java
Show resolved
Hide resolved
mosabua
commented
Nov 4, 2024
mosabua
force-pushed
the
sparse-distance
branch
4 times, most recently
from
4b126bf to
cb8d293
Compare
mosabua
commented
Nov 8, 2024
| assertThat(assertions.function("cosine_distance", "null", "map(ARRAY['c', 'b'], ARRAY[1.0E0, 3.0E0])")) | ||
| .isNull(); | ||
|
|
||
| //assertThat(assertions.function("cosine_distance", "map(ARRAY['a', 'b'], ARRAY[1.0E0, null])", "map(ARRAY['c', 'b'], ARRAY[1.0E0, 3.0E0])")) |
There was a problem hiding this comment.
This fails but have not looked into it
There was a problem hiding this comment.
The failure was an NPE due to invalid input parameters in my opinion.. so I deleted that assertion.
|
This pull request has gone a while without any activity. Tagging for triage help: @mosabua |
|
I need to look at the test that failed and chat some more with @martint afterwards. I will keep it open and update after Trino Summit. |
|
This pull request has gone a while without any activity. Tagging for triage help: @mosabua |
mosabua
force-pushed
the
sparse-distance
branch
from
cb8d293 to
74e4109
Compare
mosabua
force-pushed
the
sparse-distance
branch
from
74e4109 to
c0211d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Still have to test this locally...
Additional context and related issues
follow up to #24005
Release notes
(*) Release notes are required, with the following suggested text: