Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade coral for 2.2.23 #20402

Closed
wants to merge 1 commit into from

Conversation

jerryleooo
Copy link
Member

Fix different definitions of substr in Hive and Trino

Additional context and related issues

#18099
linkedin/coral#433

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix different definitions of `substr` in Hive and Trino (#18099 )

Copy link

cla-bot bot commented Jan 17, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Jerry.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@jerryleooo jerryleooo marked this pull request as draft January 17, 2024 08:35
Copy link

cla-bot bot commented Jan 17, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Jerry.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@jerryleooo jerryleooo force-pushed the upgrade-coral-2.2.23 branch from 95cf6e8 to 72b926a Compare January 17, 2024 08:38
Copy link

cla-bot bot commented Jan 17, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Jerry.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@jerryleooo jerryleooo force-pushed the upgrade-coral-2.2.23 branch from 72b926a to f4b8222 Compare January 17, 2024 08:44
Copy link

cla-bot bot commented Jan 17, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Jerry.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@ebyhr
Copy link
Member

ebyhr commented Jan 17, 2024

Could you send a PR to https://github.com/trinodb/trino-coral as well?

Also, could you add a test in AbstractTestHiveViews?

@ebyhr
Copy link
Member

ebyhr commented Apr 3, 2024

Coral reverted the change in linkedin/coral#492 and started working on linkedin/coral#499

@ebyhr
Copy link
Member

ebyhr commented Oct 2, 2024

@cla-bot check

Copy link

cla-bot bot commented Oct 2, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Jerry.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link

cla-bot bot commented Oct 2, 2024

The cla-bot has been summoned, and re-checked this pull request!

@ebyhr
Copy link
Member

ebyhr commented Oct 2, 2024

Let me close as stale PR. Please feel free to reopen if you want to continue.

@ebyhr ebyhr closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants