Revert "Add some traceability which option is failing" #20335
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d69f50b. There was a concern voiced that the resulting logs could be too big.
martint
reviewed
Jan 10, 2024
| @@ -1200,8 +1197,6 @@ public void testJoinPushdown() | |||
| "nation_lowercase", | |||
| "AS SELECT nationkey, lower(name) name, regionkey FROM nation")) { | |||
| for (JoinOperator joinOperator : JoinOperator.values()) { | |||
| log.info("Testing joinOperator=%s", joinOperator); | |||
There was a problem hiding this comment.
You can replace it with a describedAs(...) in the assertion that indicates which join operator is being evaluated. That will be included in the failure message.
|
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
|
I assume this is still in the works @findepi |
|
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
|
Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time. |
findepi
deleted the
findepi/revert-add-some-traceability-which-option-is-failing-56ad12
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit d69f50b. There was a concern voiced that the resulting logs could be too big.