Fix TestTrinoGlueCatalog.testListTables #20325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
approved these changes
Jan 10, 2024
findepi
added
no-release-notes
findepi
force-pushed
the
findepi/fix-testtrinogluecatalog-testlisttables-284ca5
branch
from
9a18ddb to
c37ca76
Compare
Make it use unique namespace names and add cleanup.
findepi
force-pushed
the
findepi/fix-testtrinogluecatalog-testlisttables-284ca5
branch
from
c37ca76 to
820be74
Compare
wendigo
approved these changes
Jan 11, 2024
wendigo
reviewed
Jan 11, 2024
| // Namespace is provided and does not exist | ||
| assertThat(catalog.listTables(SESSION, Optional.of("non_existing"))).isEmpty(); | ||
|
|
||
| try (AutoCloseableCloser closer = AutoCloseableCloser.create()) { |
wendigo
deleted the
findepi/fix-testtrinogluecatalog-testlisttables-284ca5
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it use unique namespace names and add cleanup.
Fixes #20324