Cache result of evaluating constraint per partition in iceberg #20304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sopel39
approved these changes
Jan 9, 2024
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergSplitSource.java
Show resolved
Hide resolved
findepi
approved these changes
Jan 9, 2024
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergSplitSource.java
Outdated
Show resolved
Hide resolved
findinpath
reviewed
Jan 9, 2024
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergSplitSource.java
Outdated
Show resolved
Hide resolved
findinpath
reviewed
Jan 9, 2024
| } | ||
| Map<ColumnHandle, NullableValue> partitionValues = partitionValuesSupplier.get(); | ||
| try { | ||
| return partitionConstraintResults.get(ImmutableMap.copyOf(Maps.filterKeys(partitionValues, predicatePartitionColumns::contains))); |
There was a problem hiding this comment.
Should the filtering of the partitionValues map keys be a preparatory commit?
There was a problem hiding this comment.
I'm only doing that to improve hit rate for cache when there are multiple partitioning columns and predicate is only on a subset of the partitioning columns.
I don't think we would get a benefit from doing this in the previous code.
findinpath
reviewed
Jan 9, 2024
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergSplitSource.java
Outdated
Show resolved
Hide resolved
findinpath
approved these changes
Jan 9, 2024
findepi
reviewed
Jan 9, 2024
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergSplitSource.java
Outdated
Show resolved
Hide resolved
|
Ran TPC sf1k iceberg partitioned parquet benchmarks 
Not much change, which is expected since there aren't many files per partition or complex partition constraints to be evaluated in TPC sf1k.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently we evaluate constraint on partitioning columns for every file in iceberg
split source. This change caches the result of constraint evaluation to avoid repeating
this computation for every file in a partition.
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: