Detect leaked containers when running with JUnit #20297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
added
test
no-release-notes
|
cc @trinodb/maintainers |
findepi
force-pushed
the
findepi/container-leaks
branch
2 times, most recently
from
d797f4f to
9a0a82f
Compare
|
Example in action - https://github.com/trinodb/trino/actions/runs/7447757866/job/20260913999 |
losipiuk
reviewed
Jan 8, 2024
| log.info("Checking for leaked containers"); | ||
|
|
||
| try (DockerClient client = DockerClientFactory.instance().client()) { | ||
| List<Container> containers = client.listContainersCmd() |
There was a problem hiding this comment.
are containers immediately removed - are we sure those are gone by now?
There was a problem hiding this comment.
yes, normally they are removed with equivalent of docker rm -f, so immediate
With TestNG, `ManageTestResources` was attempting to prevent resource leaks, including container leaks, in tests. It relied on certain common test patterns to operate (like storing resource on instance fields). This commit attempts to provide similar functionality for JUnit. For now it's limited to containers. As an added bonus, it works regardless of how the test class is written.
findepi
force-pushed
the
findepi/container-leaks
branch
from
9a0a82f to
9eb75d5
Compare
|
Found a container leak in accumulo tests, in TestingAccumuloServer class. That one is intentional though, so added suppression mechanism. |
losipiuk
approved these changes
Jan 8, 2024
ssheikin
added a commit
to ssheikin/testcontainers-java
that referenced
this pull request
Oct 30, 2024
reportLeakedContainers adapted from trinodb/trino#20297 trinodb/trino#21280 Co-authored-by: Piotr Findeisen <piotr.findeisen@gmail.com> Co-authored-by: Jan Waś <jan.was@starburstdata.com>
ssheikin
added a commit
to ssheikin/testcontainers-java
that referenced
this pull request
Oct 31, 2024
reportLeakedContainers adapted from trinodb/trino#20297 trinodb/trino#21280 Co-authored-by: Piotr Findeisen <piotr.findeisen@gmail.com> Co-authored-by: Jan Waś <jan.was@starburstdata.com>
ssheikin
added a commit
to ssheikin/testcontainers-java
that referenced
this pull request
Nov 5, 2024
reportLeakedContainers adapted from trinodb/trino#20297 trinodb/trino#21280 Co-authored-by: Piotr Findeisen <piotr.findeisen@gmail.com> Co-authored-by: Jan Waś <jan.was@starburstdata.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With TestNG,
ManageTestResourceswas attempting to prevent resource leaks, including container leaks, in tests. It relied on certain common test patterns to operate (like storing resource on instance fields).This commit attempts to provide similar functionality for JUnit. For now it's limited to containers. As an added bonus, it works regardless of how the test class is written.