Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore FTE tests increased parallelism on CI #20295

Conversation

findepi
Copy link
Member

@findepi findepi commented Jan 8, 2024

We used threadCount=4 for FTE tests to make them complete faster. Since GitHub runners typically have 2 cores, JUnit default parallelism is now smaller. Increase it back.

We used `threadCount=4` for FTE tests to make them complete faster.
Since GitHub runners typically have 2 cores, JUnit default parallelism
is now smaller. Increase it back.
@findepi
Copy link
Member Author

findepi commented Jan 8, 2024

Before the change, Maven Tests step of the test (testing/trino-faulttolerant-tests, test-fault-tolerant-hive) job was within 14-15m and it still is. Maybe I am missing something, but it looks that either the configuration change is not effective, or it doesn't make run tests faster.

@findepi findepi marked this pull request as draft January 8, 2024 12:56
@findepi findepi closed this Jan 8, 2024
@findepi findepi deleted the findepi/restore-fte-tests-increased-parallelism-on-ci-be4fe4 branch January 8, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants