Iceberg system tables code cleanup #20265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were made obsolete by commit 62acd1b.
github-actions
bot
added
iceberg
losipiuk
reviewed
Jan 3, 2024
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
Outdated
Show resolved
Hide resolved
losipiuk
approved these changes
Jan 3, 2024
Like in Hive connector, return table not found instead of exception when querying `$partitions` (not prefixed with a table name).
Some names were rejected with `TrinoException` and some with graceful fallback (`return Optional.empty`). Since name validity is now checked by `IcebergTableName.isIcebergTableName` we do not need to be lax in all other methods.
findepi
force-pushed
the
findepi/dollar
branch
from
28f8e56 to
0c17004
Compare
findinpath
approved these changes
Jan 4, 2024
| @@ -965,13 +965,6 @@ public void createTable(ConnectorSession session, ConnectorTableMetadata tableMe | |||
|
|
|||
| Table table = buildTable(session, schemaTableName, location, external); | |||
|
|
|||
| // Ensure the table has queryId set. This is relied on for exception handling | |||
There was a problem hiding this comment.
This commit seems not related to the current PR
There was a problem hiding this comment.
It's separate commit. I don't think there is a point in extracting this to a separate pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.