Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only log null spooling stats in FTE mode #20216

Merged
merged 1 commit into from
Dec 26, 2023

Only log null spooling stats in FTE mode

7035257
Select commit
Loading
Failed to load commit list.
Refresh
Sign in for the full log view
Merged

Only log null spooling stats in FTE mode #20216

Only log null spooling stats in FTE mode
7035257
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Report failed Dec 26, 2023 in 0s

96575 tests run, 3237 skipped, 2 failed.

Annotations

Check failure on line 1 in io/trino/sql/planner/TestPredicatePushdown

See this annotation in the file changed.

@github-actions github-actions / Test Report

TestPredicatePushdown.testDoesNotCreatePredicateFromInferredPredicate 

Plan does not match, expected [

- node(OutputNode)
    - node(JoinNode)
        JoinMatcher{type=INNER, equiCriteria=[L_NATIONKEY = R_NATIONKEY], distributionType=Optional.empty, dynamicFilter=Optional.empty}
        - node(FilterNode)
            FilterMatcher{predicate=true}
            - node(TableScanNode)
                TableScanMatcher{expectedTableName=nation}
                bind L_NATIONKEY -> Column nation:nationkey
        - anyTree
            - node(TableScanNode)
                TableScanMatcher{expectedTableName=nation}
                bind R_NATIONKEY -> Column nation:nationkey

] but found [

Output[columnNames = [nationkey, name, regionkey, comment, nationkey2, nationkey, name, regionkey, comment]]
│   Layout: [nationkey:bigint, name:varchar(25), regionkey:bigint, comment:varchar(152), expr:bigint, nationkey:bigint, name_2:varchar(25), regionkey_3:bigint, comment_4:varchar(152)]
│   nationkey2 := expr
│   name := name_2
│   regionkey := regionkey_3
│   comment := comment_4
└─ InnerJoin[criteria = ("nationkey" = "nationkey_1"), distribution = REPLICATED]
   │   Layout: [nationkey:bigint, regionkey:bigint, name:varchar(25), comment:varchar(152), expr:bigint, name_2:varchar(25), regionkey_3:bigint, comment_4:varchar(152)]
   │   Distribution: REPLICATED
   │   dynamicFilterAssignments = {nationkey_1 -> #df_303}
   ├─ ScanFilterProject[table = test_catalog:tiny:nation, dynamicFilters = {"nationkey" = #df_303}]
   │      Layout: [nationkey:bigint, regionkey:bigint, name:varchar(25), comment:varchar(152), expr:bigint]
   │      expr := ("nationkey" + BIGINT '1')
   │      nationkey := tpch:nationkey
   │      regionkey := tpch:regionkey
   │      name := tpch:name
   │      comment := tpch:comment
   └─ LocalExchange[partitioning = SINGLE]
      │   Layout: [nationkey_1:bigint, name_2:varchar(25), regionkey_3:bigint, comment_4:varchar(152)]
      └─ TableScan[table = test_catalog:tiny:nation]
             Layout: [nationkey_1:bigint, name_2:varchar(25), regionkey_3:bigint, comment_4:varchar(152)]
             name_2 := tpch:name
             comment_4 := tpch:comment
             nationkey_1 := tpch:nationkey
             regionkey_3 := tpch:regionkey

]
Raw output 
java.lang.AssertionError: 
Plan does not match, expected [

- node(OutputNode)
    - node(JoinNode)
        JoinMatcher{type=INNER, equiCriteria=[L_NATIONKEY = R_NATIONKEY], distributionType=Optional.empty, dynamicFilter=Optional.empty}
        - node(FilterNode)
            FilterMatcher{predicate=true}
            - node(TableScanNode)
                TableScanMatcher{expectedTableName=nation}
                bind L_NATIONKEY -> Column nation:nationkey
        - anyTree
            - node(TableScanNode)
                TableScanMatcher{expectedTableName=nation}
                bind R_NATIONKEY -> Column nation:nationkey

] but found [

Output[columnNames = [nationkey, name, regionkey, comment, nationkey2, nationkey, name, regionkey, comment]]
│   Layout: [nationkey:bigint, name:varchar(25), regionkey:bigint, comment:varchar(152), expr:bigint, nationkey:bigint, name_2:varchar(25), regionkey_3:bigint, comment_4:varchar(152)]
│   nationkey2 := expr
│   name := name_2
│   regionkey := regionkey_3
│   comment := comment_4
└─ InnerJoin[criteria = ("nationkey" = "nationkey_1"), distribution = REPLICATED]
   │   Layout: [nationkey:bigint, regionkey:bigint, name:varchar(25), comment:varchar(152), expr:bigint, name_2:varchar(25), regionkey_3:bigint, comment_4:varchar(152)]
   │   Distribution: REPLICATED
   │   dynamicFilterAssignments = {nationkey_1 -> #df_303}
   ├─ ScanFilterProject[table = test_catalog:tiny:nation, dynamicFilters = {"nationkey" = #df_303}]
   │      Layout: [nationkey:bigint, regionkey:bigint, name:varchar(25), comment:varchar(152), expr:bigint]
   │      expr := ("nationkey" + BIGINT '1')
   │      nationkey := tpch:nationkey
   │      regionkey := tpch:regionkey
   │      name := tpch:name
   │      comment := tpch:comment
   └─ LocalExchange[partitioning = SINGLE]
      │   Layout: [nationkey_1:bigint, name_2:varchar(25), regionkey_3:bigint, comment_4:varchar(152)]
      └─ TableScan[table = test_catalog:tiny:nation]
             Layout: [nationkey_1:bigint, name_2:varchar(25), regionkey_3:bigint, comment_4:varchar(152)]
             name_2 := tpch:name
             comment_4 := tpch:comment
             nationkey_1 := tpch:nationkey
             regionkey_3 := tpch:regionkey

]
	at io.trino.sql.planner.assertions.PlanAssert.assertPlan(PlanAssert.java:58)
	at io.trino.sql.planner.assertions.PlanAssert.assertPlan(PlanAssert.java:49)
	at io.trino.sql.planner.assertions.PlanAssert.assertPlan(PlanAssert.java:43)
	at io.trino.sql.planner.assertions.BasePlanTest.lambda$assertPlan$2(BasePlanTest.java:155)
	at io.trino.testing.TransactionBuilder.execute(TransactionBuilder.java:162)
	at io.trino.testing.LocalQueryRunner.inTransaction(LocalQueryRunner.java:879)
	at io.trino.testing.LocalQueryRunner.inTransaction(LocalQueryRunner.java:872)
	at io.trino.sql.planner.assertions.BasePlanTest.assertPlan(BasePlanTest.java:153)
	at io.trino.sql.planner.assertions.BasePlanTest.assertPlan(BasePlanTest.java:133)
	at io.trino.sql.planner.assertions.BasePlanTest.assertPlan(BasePlanTest.java:121)
	at io.trino.sql.planner.AbstractPredicatePushdownTest.testDoesNotCreatePredicateFromInferredPredicate(AbstractPredicatePushdownTest.java:489)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.concurrent.RecursiveAction.exec(RecursiveAction.java:194)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:387)
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.tryRemoveAndExec(ForkJoinPool.java:1351)
	at java.base/java.util.concurrent.ForkJoinTask.awaitDone(ForkJoinTask.java:422)
	at java.base/java.util.concurrent.ForkJoinTask.join(ForkJoinTask.java:651)
	at java.base/java.util.concurrent.RecursiveAction.exec(RecursiveAction.java:194)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:387)
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1312)
	at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1843)
	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1808)
	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:188)
	Suppressed: java.lang.Exception: Query: SELECT * FROM (SELECT *, nationkey + 1 as nationkey2 FROM nation) a JOIN nation b ON a.nationkey = b.nationkey
		at io.trino.sql.planner.assertions.BasePlanTest.assertPlan(BasePlanTest.java:160)
		... 15 more

Check failure on line 183 in io/trino/sql/planner/TestPredicatePushdownWithoutDynamicFilter

See this annotation in the file changed.

@github-actions github-actions / Test Report

TestPredicatePushdownWithoutDynamicFilter.testDoesNotCreatePredicateFromInferredPredicate 

Plan does not match, expected [

- node(OutputNode)
    - node(JoinNode)
        JoinMatcher{type=INNER, equiCriteria=[L_NATIONKEY = R_NATIONKEY], distributionType=Optional.empty, dynamicFilter=Optional.empty}
        - node(TableScanNode)
            TableScanMatcher{expectedTableName=nation}
            bind L_NATIONKEY -> Column nation:nationkey
        - anyTree
            - node(TableScanNode)
                TableScanMatcher{expectedTableName=nation}
                bind R_NATIONKEY -> Column nation:nationkey

] but found [

Output[columnNames = [nationkey, name, regionkey, comment, nationkey2, nationkey, name, regionkey, comment]]
│   Layout: [nationkey:bigint, name:varchar(25), regionkey:bigint, comment:varchar(152), expr:bigint, nationkey:bigint, name_2:varchar(25), regionkey_3:bigint, comment_4:varchar(152)]
│   nationkey2 := expr
│   name := name_2
│   regionkey := regionkey_3
│   comment := comment_4
└─ InnerJoin[criteria = ("nationkey" = "nationkey_1"), distribution = REPLICATED]
   │   Layout: [nationkey:bigint, regionkey:bigint, name:varchar(25), comment:varchar(152), expr:bigint, name_2:varchar(25), regionkey_3:bigint, comment_4:varchar(152)]
   │   Distribution: REPLICATED
   ├─ ScanProject[table = test_catalog:tiny:nation]
   │      Layout: [nationkey:bigint, regionkey:bigint, name:varchar(25), comment:varchar(152), expr:bigint]
   │      expr := ("nationkey" + BIGINT '1')
   │      nationkey := tpch:nationkey
   │      regionkey := tpch:regionkey
   │      name := tpch:name
   │      comment := tpch:comment
   └─ LocalExchange[partitioning = SINGLE]
      │   Layout: [nationkey_1:bigint, name_2:varchar(25), regionkey_3:bigint, comment_4:varchar(152)]
      └─ TableScan[table = test_catalog:tiny:nation]
             Layout: [nationkey_1:bigint, name_2:varchar(25), regionkey_3:bigint, comment_4:varchar(152)]
             name_2 := tpch:name
             comment_4 := tpch:comment
             nationkey_1 := tpch:nationkey
             regionkey_3 := tpch:regionkey

]
Raw output 
java.lang.AssertionError: 
Plan does not match, expected [

- node(OutputNode)
    - node(JoinNode)
        JoinMatcher{type=INNER, equiCriteria=[L_NATIONKEY = R_NATIONKEY], distributionType=Optional.empty, dynamicFilter=Optional.empty}
        - node(TableScanNode)
            TableScanMatcher{expectedTableName=nation}
            bind L_NATIONKEY -> Column nation:nationkey
        - anyTree
            - node(TableScanNode)
                TableScanMatcher{expectedTableName=nation}
                bind R_NATIONKEY -> Column nation:nationkey

] but found [

Output[columnNames = [nationkey, name, regionkey, comment, nationkey2, nationkey, name, regionkey, comment]]
│   Layout: [nationkey:bigint, name:varchar(25), regionkey:bigint, comment:varchar(152), expr:bigint, nationkey:bigint, name_2:varchar(25), regionkey_3:bigint, comment_4:varchar(152)]
│   nationkey2 := expr
│   name := name_2
│   regionkey := regionkey_3
│   comment := comment_4
└─ InnerJoin[criteria = ("nationkey" = "nationkey_1"), distribution = REPLICATED]
   │   Layout: [nationkey:bigint, regionkey:bigint, name:varchar(25), comment:varchar(152), expr:bigint, name_2:varchar(25), regionkey_3:bigint, comment_4:varchar(152)]
   │   Distribution: REPLICATED
   ├─ ScanProject[table = test_catalog:tiny:nation]
   │      Layout: [nationkey:bigint, regionkey:bigint, name:varchar(25), comment:varchar(152), expr:bigint]
   │      expr := ("nationkey" + BIGINT '1')
   │      nationkey := tpch:nationkey
   │      regionkey := tpch:regionkey
   │      name := tpch:name
   │      comment := tpch:comment
   └─ LocalExchange[partitioning = SINGLE]
      │   Layout: [nationkey_1:bigint, name_2:varchar(25), regionkey_3:bigint, comment_4:varchar(152)]
      └─ TableScan[table = test_catalog:tiny:nation]
             Layout: [nationkey_1:bigint, name_2:varchar(25), regionkey_3:bigint, comment_4:varchar(152)]
             name_2 := tpch:name
             comment_4 := tpch:comment
             nationkey_1 := tpch:nationkey
             regionkey_3 := tpch:regionkey

]
	at io.trino.sql.planner.assertions.PlanAssert.assertPlan(PlanAssert.java:58)
	at io.trino.sql.planner.assertions.PlanAssert.assertPlan(PlanAssert.java:49)
	at io.trino.sql.planner.assertions.PlanAssert.assertPlan(PlanAssert.java:43)
	at io.trino.sql.planner.assertions.BasePlanTest.lambda$assertPlan$2(BasePlanTest.java:155)
	at io.trino.testing.TransactionBuilder.execute(TransactionBuilder.java:162)
	at io.trino.testing.LocalQueryRunner.inTransaction(LocalQueryRunner.java:879)
	at io.trino.testing.LocalQueryRunner.inTransaction(LocalQueryRunner.java:872)
	at io.trino.sql.planner.assertions.BasePlanTest.assertPlan(BasePlanTest.java:153)
	at io.trino.sql.planner.assertions.BasePlanTest.assertPlan(BasePlanTest.java:133)
	at io.trino.sql.planner.assertions.BasePlanTest.assertPlan(BasePlanTest.java:121)
	at io.trino.sql.planner.TestPredicatePushdownWithoutDynamicFilter.testDoesNotCreatePredicateFromInferredPredicate(TestPredicatePushdownWithoutDynamicFilter.java:183)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.concurrent.RecursiveAction.exec(RecursiveAction.java:194)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:387)
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.tryRemoveAndExec(ForkJoinPool.java:1351)
	at java.base/java.util.concurrent.ForkJoinTask.awaitDone(ForkJoinTask.java:422)
	at java.base/java.util.concurrent.ForkJoinTask.join(ForkJoinTask.java:651)
	at java.base/java.util.concurrent.RecursiveAction.exec(RecursiveAction.java:194)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:387)
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1312)
	at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1843)
	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1808)
	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:188)
	Suppressed: java.lang.Exception: Query: SELECT * FROM (SELECT *, nationkey + 1 as nationkey2 FROM nation) a JOIN nation b ON a.nationkey = b.nationkey
		at io.trino.sql.planner.assertions.BasePlanTest.assertPlan(BasePlanTest.java:160)
		... 15 more
View more details on GitHub Actions