Only log null spooling stats in FTE mode #20216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
approved these changes
Dec 23, 2023
core/trino-main/src/main/java/io/trino/server/remotetask/HttpRemoteTask.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/server/remotetask/TaskInfoFetcher.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Dec 24, 2023
core/trino-main/src/main/java/io/trino/server/remotetask/TaskInfoFetcher.java
Outdated
Show resolved
Hide resolved
dekimir
added a commit
to dekimir/trino
that referenced
this pull request
Dec 26, 2023
dekimir
added a commit
to dekimir/trino
that referenced
this pull request
Dec 26, 2023
dekimir
added a commit
to dekimir/trino
that referenced
this pull request
Dec 26, 2023
In pipelined mode, the spooling stats are always null, which fills the log needlessly. trinodb#20214 (comment)
dekimir
force-pushed
the
log-spoolingnull-fte-only
branch
from
418d8f8 to
7035257
Compare
|
trino-main failure is unrelated. Introduced by @sopel39 commit :) |
wendigo
approved these changes
Dec 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In pipelined mode, the spooling stats are always null, which fills the log needlessly. We want to catch this nullification only in FTE mode.
Additional context and related issues
#20214 (comment)
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: