Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracing for query start #20195

Merged

Conversation

findepi
Copy link
Member

@findepi findepi commented Dec 21, 2023

Query start may be time consuming operation and should be traced. Especially in case of DataDefinitionExecution, the start may cover all of the query execution.

Fixes #20193

Query start may be time consuming operation and should be traced.
Especially in case of `DataDefinitionExecution`, the start may cover all
of the query execution.
Copy link
Member

@sopel39 sopel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it fix #20193?

@wendigo wendigo merged commit 11e8530 into trinodb:master Dec 21, 2023
88 checks passed
@github-actions github-actions bot added this to the 436 milestone Dec 21, 2023
@findepi findepi deleted the findepi/add-tracing-for-query-start-eff716 branch December 21, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

DDL queries don't propagate traces
3 participants