Add tracing for SplitManager.getSplits #20194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes, `ConnectorSplitManager.getSplits` can take long to construct `ConnectorSplitSource`. For example, in Delta, there is IO work being done before `ConnectorSplitSource` is returned. This work would better be delayed until `ConnectorSplitSource.getNextBatch` is invoked, but currently this is not the case. Let's add tracing so that time spent in `ConnectorSplitManager.getSplits` is attributable.
findepi
added
the
no-release-notes
The parameter refers to "a stage span", not to the top level "query span".
nineinchnick
approved these changes
Dec 21, 2023
|
cc: @lukasz-stec were we thinking about similar for PageSourceProvider for system tables? |
wendigo
approved these changes
Dec 21, 2023
|
thanks @wendigo for restarting the failed builds |
findepi
deleted the
findepi/add-tracing-for-splitmanager-getsplits-35e094
branch
findepi
restored the
findepi/add-tracing-for-splitmanager-getsplits-35e094
branch
findepi
deleted the
findepi/add-tracing-for-splitmanager-getsplits-35e094
branch
@hashhar I wasn't thinking about that but yes, it looks useful. That said tracing is already there for most of stuff via TracingMetadata, it just not linked to the parent span correctly I believe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes,
ConnectorSplitManager.getSplitscan take long to constructConnectorSplitSource. For example, in Delta, there is IO work being done beforeConnectorSplitSourceis returned. This work would better be delayed untilConnectorSplitSource.getNextBatchis invoked, but currently this is not the case. Let's add tracing so that time spent inConnectorSplitManager.getSplitsis attributable.