-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw IndexOutOfBoundsException in MemoryInputStream #19813
Throw IndexOutOfBoundsException in MemoryInputStream #19813
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we need to add the same check to HdfsTrinoInputStream
@jkylling can you please apply this comment and fix test failure here ? |
f3348d9
to
ce5ca91
Compare
I'm unable to run the
|
ce5ca91
to
467bcb6
Compare
@jkylling please shorten a first line of a commit message according to our guidelines. I'll merge this change then |
467bcb6
to
8cda0ee
Compare
Thanks @raunaqmorarka ! |
Description
InputStream.read is expected to throw IndexOutOfBoundException when
We currently don't test this, and allow using
MemoryInputStream.read
with a negative offset.Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: