Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement NOT, IS NULL, NOT IS NULL pushdown in Ignite connector #19451

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Implement NOT, IS NULL, NOT IS NULL pushdown in Ignite connector #19451

merged 1 commit into from
Dec 1, 2023

Conversation

chenjian2664
Copy link
Contributor

@chenjian2664 chenjian2664 commented Oct 19, 2023 •
edited by ebyhr
Loading

Description

Close 19453

Additional context and related issues

Release notes

(x) Release notes are required, with the following suggested text:

# Ignite
* Improve performance of queries involving `OR` with `IS NULL`, `IS NOT NULL`
  predicates, or involving `NOT` expression by pushing predicate computation to
  the Ignite database. ({issue}`19453`)

@cla-bot cla-bot bot added the cla-signed label Oct 19, 2023
@chenjian2664 chenjian2664 requested review from wendigo and ebyhr October 23, 2023 14:56
@ebyhr ebyhr removed their request for review October 27, 2023 02:53
@ebyhr
Copy link
Member

ebyhr commented Nov 29, 2023

Please rebase on master to resolve conflicts.

@chenjian2664 @ebyhr
Implement NOT, IS NULL, NOT IS NULL pushdown in Ignite connector
0e80ac3 
Co-Authored-By: Yuya Ebihara <ebyhry@gmail.com>
@ebyhr ebyhr merged commit 78ccc2d into trinodb:master Dec 1, 2023
18 checks passed
@github-actions github-actions bot added this to the 435 milestone Dec 1, 2023
@chenjian2664 chenjian2664 deleted the ignite_not branch December 1, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebyhr ebyhr ebyhr approved these changes

@wendigo wendigo Awaiting requested review from wendigo

Assignees
No one assigned
Labels
cla-signed
Milestone
435
Development

Successfully merging this pull request may close these issues.

Implement NOT, IS NULL, NOT IS NULL pushdown in Ignite connector
2 participants
@chenjian2664 @ebyhr