Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable writing to full ACID tables in Hive connector when the table has no partitions #19447

Conversation

cpcloud
Copy link
Contributor

@cpcloud cpcloud commented Oct 19, 2023

Description

Allow inserting into a full-ACID Hive table without partitions.

See that issue for a full description.

Fixes #19407.

Additional context and related issues

N/A

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:

# Section
* Allow Allow inserting into a full-ACID Hive table without partitions. ({issue}`19407`)

@cla-bot cla-bot bot added the cla-signed label Oct 19, 2023
@github-actions github-actions bot added tests:hive hive Hive connector labels Oct 19, 2023
@cpcloud
Copy link
Contributor Author

cpcloud commented Oct 19, 2023

@electrum I couldn't find any existing unit tests that directly invoke finishMerge. Is there another place or approach I should use to test this change?

@cpcloud cpcloud force-pushed the fix-inserting-into-partitionless-hive-acid-table branch from c9d094d to 075c514 Compare October 19, 2023 09:55
@cpcloud
Copy link
Contributor Author

cpcloud commented Oct 19, 2023

Ok, grepping around I found testing/trino-product-tests/src/main/java/io/trino/tests/product/hive/TestWriteToHiveTransactionalTableInTrino.java which looks like it might be the place to add a test for this.

@cpcloud cpcloud force-pushed the fix-inserting-into-partitionless-hive-acid-table branch from 075c514 to 0deb800 Compare October 19, 2023 11:24
@cpcloud
Copy link
Contributor Author

cpcloud commented Dec 9, 2023

@electrum Any chance this will get merged?

@hashhar hashhar requested a review from electrum December 13, 2023 08:25
Copy link

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Jan 10, 2024
@mosabua
Copy link
Member

mosabua commented Jan 11, 2024

@electrum or @findepi .. anyone available to review and help @cpcloud ?

@findepi
Copy link
Member

findepi commented Jan 11, 2024

cc @Praveen2112 @kokosing

@github-actions github-actions bot removed the stale label Jan 12, 2024
Copy link

github-actions bot commented Feb 2, 2024

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Feb 2, 2024
Copy link

Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.

@github-actions github-actions bot closed this Feb 28, 2024
@cpcloud cpcloud reopened this Feb 28, 2024
@cpcloud
Copy link
Contributor Author

cpcloud commented Feb 28, 2024

Ping @electrum @mosabua @findepi @Praveen2112.

What's holding this PR up?

@electrum electrum merged commit 3bc1789 into trinodb:master Feb 28, 2024
112 checks passed
@github-actions github-actions bot added this to the 440 milestone Feb 28, 2024
@cpcloud cpcloud deleted the fix-inserting-into-partitionless-hive-acid-table branch February 28, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Unable to insert into transactional table without partitions
4 participants