Add "test" environment tag to temporary S3 test buckets used by CI #19359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nineinchnick
approved these changes
Oct 11, 2023
wendigo
approved these changes
Oct 11, 2023
|
should test with secrets before merging to be safe |
|
/test-with-secrets sha=d0ddcef365202c2a96261709df5d267d61710016 |
|
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/6493317940 |
|
@charlesjmorgan please rebase |
The tag with key "environment" and value "test" is needed so that the temporary S3 buckets used for testing can be cleaned up by the daily AWS resource cleanup job if they aren't deleted by the ci workflow run.
charlesjmorgan
force-pushed
the
cm/s3-add-environment-tag
branch
from
d0ddcef to
1a984c2
Compare
|
I cannot. It doesn't work for me @charlesjmorgan |
|
/test-with-secrets sha=1a984c2e488f4aa36f20c4ef60311de1a350de7c |
|
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/6585236862 |
|
Failures in BQ are unrelated. I'm going to merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The tag with key "environment" and value "test" is needed so that the temporary S3 buckets used for testing can be cleaned up by the daily AWS resource cleanup job if they aren't deleted by the ci workflow run.
Additional context and related issues
#19060
#19248
Release notes
(X) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: