Add validation for missing Test annotations #19358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tests:hive
hudi
wendigo
approved these changes
Oct 12, 2023
findepi
reviewed
Oct 13, 2023
| @@ -42,6 +42,12 @@ | |||
| <artifactId>antlr4-runtime</artifactId> | |||
| </dependency> | |||
|
|
|||
| <dependency> | |||
| <groupId>io.airlift</groupId> | |||
| <artifactId>junit-extensions</artifactId> | |||
There was a problem hiding this comment.
This is very brittle. It only works if a module depends on junit-extensions. To ensure it applies to everything, the extension should be registered via the surefire plugin configuration.
There was a problem hiding this comment.
There’s a bug or limitation preventing that right now, but yes, that’s the way it should be.
The benefit of this being in a separate library is that it can be used in every module in Trino. The implementation in that other PR limited it to downstream modules due to potential circular deos.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.