Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default implementation of withoutSmallFileThreshold #19355

Conversation

findepi
Copy link
Member

@findepi findepi commented Oct 11, 2023

The default implementation did not do anything, which is not suitable for the test.

@findepi findepi added the no-release-notes This pull request does not require release notes entry label Oct 11, 2023
@cla-bot cla-bot bot added the cla-signed label Oct 11, 2023
Copy link
Member

@raunaqmorarka raunaqmorarka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There can be connectors like mongoDB where we're testing reduction in physical data read due to projection and predicate pushdown but the small file optimization doesn't apply there

@findepi
Copy link
Member Author

findepi commented Oct 13, 2023

Can you add a code comment in withoutSmallFileThreshold explaining why default impl isn't needed?

also, if it's sometimes not needed, and sometimes it is needed, it\d be better not to have default implementation still, and have a no-op impl for connectors where this is suitable

@raunaqmorarka
Copy link
Member

Can you add a code comment in withoutSmallFileThreshold explaining why default impl isn't needed?

also, if it's sometimes not needed, and sometimes it is needed, it\d be better not to have default implementation still, and have a no-op impl for connectors where this is suitable

It looks like this change is fine for now as MongoDb is skipping this test. We can let connectors add no-op implementation if needed later.

The default implementation did not do anything, which is not suitable
for the test.
@findepi findepi force-pushed the findepi/remove-default-implementation-of-withoutsmallfilethreshold-7dde69 branch from f541b89 to 64e936d Compare October 16, 2023 15:05
@findepi
Copy link
Member Author

findepi commented Oct 16, 2023

( just rebased, no other changes )

@findepi findepi merged commit c65a2d6 into trinodb:master Oct 17, 2023
83 checks passed
@findepi findepi deleted the findepi/remove-default-implementation-of-withoutsmallfilethreshold-7dde69 branch October 17, 2023 11:18
@github-actions github-actions bot added this to the 430 milestone Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed no-release-notes This pull request does not require release notes entry
Development

Successfully merging this pull request may close these issues.

2 participants