Support injecting system properties into JUnit tests

[wendigo]

Fixes broken master:

Error:  io.trino.plugin.hive.TestHiveThriftMetastoreWithS3 -- Time elapsed: 0.040 s <<< ERROR!
org.junit.jupiter.api.extension.ParameterResolutionException: No ParameterResolver registered for parameter [java.lang.String s3endpoint] in constructor [public io.trino.plugin.hive.TestHiveThriftMetastoreWithS3(java.lang.String,java.lang.String,java.lang.String,java.lang.String) throws java.io.IOException].
	at java.base/java.util.Optional.orElseGet(Optional.java:364)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

[wendigo]

Fixed test classes are running with JUnit

[findepi]

I allowed myself to merge #19337 to fix the master branch.
Please rebase & revert the revert.

[wendigo]

@findepi done

[findepi]

nit:
Define as top level class.
This helps Intellij generate imports

(for nested class Intellij strongly prefers OutClass.InnerClass syntax which is all but pretty)

[findepi]

Separate commit.

Also, just noticed that one of the overrides BaseConnectorTest#ensureTestNamingConvention, does not have @Test annotation (actually it has testng's @Test, but not Junit's @Test).
As a result, the override won't be called.
Please update BaseConnectorTest.ensureTestNamingConvention to have additional junit @Test annotation (but keep testng's for now, since all other test methods are testng's)

[findepi]

When extracting the commit please be so nice to include message from 6858091

For many test classes, this it the last method that is not converted.
For example, running TestInformationSchemaConnector with TestNG will
run only this method. Moving this will make tests like
TestInformationSchemaConnector JUnit-only and improve test overall
time (fewer createQueryRunner invocations).

Obviously, it can be the first JUnit test method for some other classes,
but

• the train cannot be stopped. We do this sooner or later.
• AbstractTestQueries are already JUnit; BaseConnectorTest extends
  from AbstractTestQueries and BaseConnectorTest are most likely to
  most expensive setups, because they create dependant services.

[wendigo]

In which order I should add this one? Because in either one one of the commits will be broken on it's own

[dain]

I'm not sure why we need this. This seems to swap:

this.alternateProjectId = requireNonNull(System.getProperty("testing.alternate-bq-project-id"), "testing.alternate-bq-project-id system property not set");

for

public TestBigQueryWithDifferentProjectIdConnectorSmokeTest(@SystemProperty("testing.alternate-bq-project-id") String alternateProjectId)
{
    this.alternateProjectId = requireNonNull(alternateProjectId, "alternateProjectId is null");
}

Is there some non-obvious improvement? If not, I don't see why we need this.

[dain]

I'm not sure why we need this complexity