Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable node cleanup for product tests #19344

Merged

Conversation

dominikzalewski
Copy link
Member

@dominikzalewski dominikzalewski commented Oct 11, 2023

Description

Product tests (build-pt) are building product test launcher and product tests jar. This makes the agent go out of available disk space. We have no idea what exactly is causing the issue, but the fix has been experimentally proven to help.

Example job that failed:
https://github.com/trinodb/trino/actions/runs/6479250735/job/17592431438
with message:

Error:  Failed to execute goal io.takari.maven.plugins:takari-lifecycle-plugin:2.1.1:install (default-install) on project trino-server: Failed to install artifact io.trino:trino-server:tar.gz:429-SNAPSHOT: No space left on device -> [Help 1]

Release notes

(X) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

This job is fetching various docker images and can easily go out of available disk space
@cla-bot cla-bot bot added the cla-signed label Oct 11, 2023
@dominikzalewski dominikzalewski marked this pull request as ready for review October 11, 2023 08:32
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

It's also a good idea to leave a link (only in PR description, not commit message) to a run that failed in case someone wants to investigate further/verify.

@wendigo
Copy link
Contributor

wendigo commented Oct 11, 2023

To be precise @dominikzalewski, build-pt is not downloading docker images but building product test launcher and product tests jar. I have no idea what's causing it to go out of disk space

@wendigo
Copy link
Contributor

wendigo commented Oct 11, 2023

build-pt succeeded. Merging to unblock master.

@wendigo wendigo merged commit fc80a93 into trinodb:master Oct 11, 2023
@dominikzalewski dominikzalewski deleted the enable_node_cleanup_for_product_tests branch October 11, 2023 09:45
@github-actions github-actions bot added this to the 429 milestone Oct 11, 2023
@dominikzalewski
Copy link
Member Author

@wendigo, @hashhar - changed the description. Hope it's what you asked for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants