Allow using fragment and query characters in S3 locations #19296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homar
force-pushed
the
homar/remove_check_against_valid_characters_in_location_class
branch
from
2201194 to
0ba6b3f
Compare
homar
force-pushed
the
homar/remove_check_against_valid_characters_in_location_class
branch
3 times, most recently
from
3f8edf1 to
3d52fc5
Compare
findinpath
approved these changes
Oct 9, 2023
guptashailesh92
approved these changes
Oct 9, 2023
findepi
reviewed
Oct 9, 2023
| @@ -61,9 +61,6 @@ public static Location of(String location) | |||
| checkArgument(!location.isEmpty(), "location is empty"); | |||
| checkArgument(!location.isBlank(), "location is blank"); | |||
|
|
|||
| checkArgument(location.indexOf('#') < 0, "Fragment is not allowed in a file system location: %s", location); | |||
| checkArgument(location.indexOf('?') < 0, "URI query component is not allowed in a file system location: %s", location); | |||
There was a problem hiding this comment.
is there anything else preventing us from using such paths correctly?
like some urlencode somewhere in delta?
would it make sense to have end-to-end tests with Delta, Hive, Iceberg?
homar
force-pushed
the
homar/remove_check_against_valid_characters_in_location_class
branch
2 times, most recently
from
ff4de3d to
0f73f16
Compare
electrum
requested changes
Oct 9, 2023
plugin/trino-hive/src/test/java/io/trino/plugin/hive/BaseHiveConnectorTest.java
Show resolved
Hide resolved
electrum
approved these changes
Oct 9, 2023
electrum
changed the title
homar
force-pushed
the
homar/remove_check_against_valid_characters_in_location_class
branch
3 times, most recently
from
6713227 to
702bb3a
Compare
homar
force-pushed
the
homar/remove_check_against_valid_characters_in_location_class
branch
from
702bb3a to
637d5d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove restrictions on the s3 path
https://trinodb.slack.com/archives/CP1MUNEUX/p1696396755060829
Release notes
(x) Release notes are required, with the following suggested text: