Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update testing ClickHouse server versions #18953

Closed
wants to merge 2 commits into from
Closed

Update testing ClickHouse server versions #18953

wants to merge 2 commits into from

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Sep 7, 2023 •
edited
Loading

Description

Update testing ClickHouse server versions because the current versions already reached EOL.

Release notes

( ) Release notes are required, with the following suggested text:

# ClickHouse
* Upgrade minimum required Clickhouse version to 22.8. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Sep 7, 2023
@github-actions github-actions bot added the docs label Sep 7, 2023
@ebyhr ebyhr force-pushed the ebi/cilckhouse-deprecated branch from e624430 to 47b5521 Compare September 7, 2023 06:47
hashhar
hashhar reviewed Sep 7, 2023
View reviewed changes
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we no longer "support" 21.4 is there some dead code present in https://github.com/trinodb/trino/blob/master/plugin/trino-clickhouse/src/main/java/io/trino/plugin/clickhouse/TrinoToClickHouseWriteChecker.java For the Date and DateTime types?

@ebyhr ebyhr force-pushed the ebi/cilckhouse-deprecated branch from 47b5521 to 3b9b822 Compare September 25, 2023 02:16
ebyhr
ebyhr commented Sep 25, 2023
View reviewed changes
plugin/trino-clickhouse/src/test/java/io/trino/plugin/clickhouse/TestClickHouseTypeMapping.java Outdated
@Test
public void testDoubleCorrectness()
{
// TODO https://github.com/trinodb/trino/issues/19138 Fix correctness failure
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#19138

@ebyhr ebyhr marked this pull request as draft September 25, 2023 02:45
@ebyhr ebyhr force-pushed the ebi/cilckhouse-deprecated branch 3 times, most recently from 170ef7e to 69fd780 Compare October 23, 2023 00:52
@ebyhr ebyhr force-pushed the ebi/cilckhouse-deprecated branch from 69fd780 to 0c14917 Compare October 23, 2023 02:48
@ebyhr
Copy link
Member Author

ebyhr commented Oct 31, 2023

Closing as #19482 is going to update the server.

@ebyhr ebyhr closed this Oct 31, 2023
@ebyhr ebyhr deleted the ebi/cilckhouse-deprecated branch October 31, 2023 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashhar hashhar hashhar left review comments

Assignees
No one assigned
Labels
cla-signed docs
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ebyhr @hashhar