Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add view reference chain information to TableInfo #18872

Closed
wants to merge 1 commit into from

Conversation

xkrogen
Copy link
Member

@xkrogen xkrogen commented Aug 30, 2023

See #18871 for more context.

This is attempting to solve the same problem, but it is scoped only for views, and does not handle row filters or column masks. This makes the required changes much smaller, by reusing TableInfo for representing the views in the reference chain, since now they are all views (not filters/masks).

I lean towards preferring #18871, since it is a more generic solution, but implemented this view-specific approach first before identifying how the scope could be expanded to include row filters / column masks, so I figured I would share it here in case others have a preference for this simpler approach.

@hashhar
Copy link
Member

hashhar commented Aug 31, 2023

FYI @Praveen2112

@xkrogen xkrogen closed this Oct 24, 2023
@xkrogen xkrogen deleted the xkrogen/viewreferencechain branch October 24, 2023 17:25
@xkrogen
Copy link
Member Author

xkrogen commented Oct 24, 2023

Closing in favor of #18871

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants