-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add partition column to the Iceberg's File metadata table #17528
Conversation
Can @findepi and @alexjo2144 please have a first look? |
2ba97c7
to
ab22fde
Compare
Could you rebase on master to resolve conflicts? |
Sure, Pardon for the delay, I’m away for few days, will do this weekend.
Thanks!
…On Mon, Jul 17, 2023 at 4:50 PM Manfred Moser ***@***.***> wrote:
Could you rebase @osscm <https://github.com/osscm> so that @ebyhr
<https://github.com/ebyhr> and others can review
—
Reply to this email directly, view it on GitHub
<#17528 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXQ2PYQZ4UHIZSLMKWS5F43XQXFVPANCNFSM6AAAAAAYEKWW5Q>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
9eb59c2
to
1e07f28
Compare
60bd438
to
776c47f
Compare
776c47f
to
fffdc50
Compare
@ebyhr rebased, now you can review please. |
can someone please help in reviewing this PR, thanks! cc @ebyhr or @findinpath or @mosabua |
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time. |
Superseded by #24102 |
Description
Adding partition column to the file metadata table.
Table has to be partitioned to access the partition column.
Underlying Iceberg DataFile/ContentFile has partition data, Spark supports and provide that information.
This information is required while debugging data issues.
ref: https://github.com/apache/iceberg/blob/master/api/src/main/java/org/apache/iceberg/ContentFile.java#L52
Additional context and related issues
fixes: #17148
Sample query
Release notes
( ) Release notes are required, with the following suggested text:
Partition column is added to the File metadata table.