Allow to override DirectoryLister #16184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Praveen2112
requested review from
atanasenko,
ebyhr,
kokosing,
findinpath and
skrzypo987
findinpath
reviewed
Feb 20, 2023
| } | ||
| else { | ||
| binder.bind(DirectoryLister.class).to(CachingDirectoryLister.class).in(Scopes.SINGLETON); | ||
| optionalBinder.setDefault().to(CachingDirectoryLister.class).in(Scopes.SINGLETON); |
There was a problem hiding this comment.
The optional binder applies only to this branch.
Allows us to bind custom DirectoryLister implementation via Guice
Praveen2112
force-pushed
the
praveen/hive_directory_lister
branch
from
2173880 to
0c02ade
Compare
|
What's the use case for overriding? |
|
We're actively working on #15921 which is going to replace |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows us to bind custom DirectoryLister implementation via Guice
Release notes
(x) This is not user-visible or docs only and no release notes are required.