Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve log message for ORC and table definition mismatch #12783

Closed
wants to merge 1 commit into from
Closed

Improve log message for ORC and table definition mismatch #12783

wants to merge 1 commit into from

Conversation

ArvinZheng
Copy link
Member

Fix #12778

@cla-bot cla-bot bot added the cla-signed label Jun 10, 2022
@electrum
Copy link
Member

Please shorten the commit title to

Improve message for ORC and table definition mismatch

@ArvinZheng
Copy link
Member Author

Please shorten the commit title to

Improve message for ORC and table definition mismatch

Updated

@ArvinZheng
Copy link
Member Author

@electrum , addressed all comments and tests are passed, pls have another look when you get a chance, thank you.

@ArvinZheng
Copy link
Member Author

@electrum mind taking another look?

@mosabua
Copy link
Member

mosabua commented Jan 15, 2024

👋 @ArvinZheng - this PR has become inactive. We hope you are still interested in working on it. Please let us know, and we can try to get reviewers to help with that.

We're working on closing out old and inactive PRs, so if you're too busy or this has too many merge conflicts to be worth picking back up, we'll be making another pass to close it out in a few weeks.

@ArvinZheng ArvinZheng changed the title Improve the log message when there are mismatches between ORC and tab… Improve log message for ORC and table definition mismatch Jan 17, 2024
@ArvinZheng
Copy link
Member Author

@mosabua just rebased the branch

@mosabua
Copy link
Member

mosabua commented Jan 17, 2024

Thank you for rebasing. This looks good to me. @electrum or @martint could you have a look?

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Sep 5, 2024
@github-actions GitHub Actions
Copy link

Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.

@github-actions github-actions bot closed this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@electrum electrum electrum left review comments

Assignees
No one assigned
Labels
cla-signed stale
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the log message when there are mismatches between ORC and table definition
4 participants
@ArvinZheng @electrum @mosabua @findepi