Skip to content

Commit

Permalink
Remove superfluous Test annotations
Browse files Browse the repository at this point in the history
Looks like one of them was added "by inertia", in the wave of adding
missing `@Test` annotations to overridden methods. The other is in
benchmarks, where it's not meaningful.
  • Loading branch information
ksobolew authored and hashhar committed Jan 25, 2024
1 parent fa26006 commit 770ca2b
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ protected QueryRunner createQueryRunner(
});
}

@Test
@Override
protected boolean areWriteRetriesSupported()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
package io.trino.plugin.geospatial;

import io.airlift.slice.Slice;
import org.junit.jupiter.api.Test;
import org.openjdk.jmh.annotations.Benchmark;
import org.openjdk.jmh.annotations.BenchmarkMode;
import org.openjdk.jmh.annotations.Fork;
Expand Down Expand Up @@ -99,7 +98,6 @@ public static void main(String[] args)
benchmark(BenchmarkSTArea.class).run();
}

@Test

This comment has been minimized.

Copy link
@martint

martint Jan 25, 2024

Member

the other is in benchmarks, where it's not meaningful.

It is meaningful. That's how we verify that the benchmarks aren't broken.

This comment has been minimized.

Copy link
@martint

martint Jan 25, 2024

Member
public static void verify()
throws IOException
{
Expand Down

0 comments on commit 770ca2b

Please sign in to comment.