Skip to content

Commit

Permalink
Switch ensureTestNamingConvention to run in JUnit to reduce test setups
Browse files Browse the repository at this point in the history
For many test classes, this it the last method that is not converted.
For example, running `TestInformationSchemaConnector` with TestNG will
run only this method. Moving this will make tests like
`TestInformationSchemaConnector` JUnit-only and improve test overall
time (fewer `createQueryRunner` invocations).

Obviously, it can be the first JUnit test method for some other classes,
but

- the train cannot be stopped. We do this sooner or later.
- `AbstractTestQueries` are already JUnit; `BaseConnectorTest` extends
  from `AbstractTestQueries` and `BaseConnectorTest` are most likely to
most expensive setups, because they create dependant services.
  • Loading branch information
findepi committed Oct 10, 2023
1 parent 65e358a commit 5669df5
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,11 @@
import org.intellij.lang.annotations.Language;
import org.junit.jupiter.api.AfterAll;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.TestInstance;
import org.testng.SkipException;
import org.testng.annotations.AfterClass;
import org.testng.annotations.BeforeClass;
import org.testng.annotations.Test;

import java.util.List;
import java.util.Map;
Expand Down

0 comments on commit 5669df5

Please sign in to comment.