Skip to content

Commit

Permalink
Increase timeout when scaling cluster in test
Browse files Browse the repository at this point in the history
Increase
`TestMinWorkerRequirement.testMultipleRequiredWorkerNodesSessionOverride`
timeout, hopefully fixing its flakiness.  Before the changes, running
the test with `@Test(invocationCount = 20, threadPoolSize = 4)` would
pretty deterministically reproduce the failure locally (with first 4
runs failing, other succeeding). It is up to future investigation to
understand why it sometimes takes more time to register new worker node.
  • Loading branch information
findepi committed Nov 7, 2023
1 parent 10fdc95 commit 0069e74
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,8 @@ private void waitForAllNodesGloballyVisible()
{
long start = System.nanoTime();
while (!allNodesGloballyVisible()) {
Assertions.assertLessThan(nanosSince(start), new Duration(10, SECONDS));
// TODO node announcement should be propagated faster when new node starts
Assertions.assertLessThan(nanosSince(start), new Duration(30, SECONDS));
MILLISECONDS.sleep(10);
}
log.info("Announced servers in %s", nanosSince(start).convertToMostSuccinctTimeUnit());
Expand Down

0 comments on commit 0069e74

Please sign in to comment.