Fixed OPA baseUri path #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vagaerg
reviewed
Aug 12, 2024
| @@ -61,7 +62,7 @@ public static class Filter | |||
| public TestingTrinoAwsProxyServer.Builder filter(TestingTrinoAwsProxyServer.Builder builder) | |||
| { | |||
| return builder.withProperty("s3-security.type", OPA_S3_SECURITY_IDENTIFIER) | |||
| .withProperty("opa-s3-security.server-base-uri", "http://localhost") | |||
| .withProperty("opa-s3-security.server-base-uri", "http://localhost:%s/v1/data".formatted(OPA_CONTAINER_PORT)) | |||
There was a problem hiding this comment.
This is not guaranteed to be 8181, 8181 is the port in the OPA container.
I think we need to keep the port resolution in the way it was implemented before
|
For context, the motivation is to let more of the settings be purely derived from config files and to make the configs more explicit. Appending |
pranavr12
force-pushed
the
opa-path-fix
branch
from
5fd1cc0 to
2a28209
Compare
pranavr12
force-pushed
the
opa-path-fix
branch
from
2a28209 to
fc2d57b
Compare
vagaerg
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.