Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix korean grammar rules for '에요/예요' #891

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

eunhyulkim
Copy link
Contributor

The Korean ending '에요/예요' varies depending on whether the preceding syllable has a final consonant, and when the preceding character is an alphabet, it follows the alphabet pronunciation rules. I corrected it accordingly.

@eunhyulkim eunhyulkim requested a review from raon0211 as a code owner December 8, 2024 13:20
Copy link

vercel bot commented Dec 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-toolkit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 8, 2024 1:24pm

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.43%. Comparing base (69c4274) to head (80c158f).
Report is 10 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #891      +/-   ##
==========================================
- Coverage   99.49%   99.43%   -0.06%     
==========================================
  Files         346      352       +6     
  Lines        2978     3034      +56     
  Branches      882      897      +15     
==========================================
+ Hits         2963     3017      +54     
- Misses         15       17       +2     

Copy link
Collaborator

@raon0211 raon0211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@raon0211 raon0211 merged commit 07ca421 into toss:main Dec 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants