feat(uniqueId): Add uniqueId to compat layer

[Na-hyunwoo]

Implemented lodash's uniqueId.

If there is anything that needs supplementation, please give me feedback.

I will fix it right away.

Thank you.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
es-toolkit	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 22, 2024 11:08pm

[dayongkr]

The functions in compat layer should pass the lodash’s test code. Please refer to the #732 PR!

[dayongkr]

And reading this issue will be helpful!

[Na-hyunwoo]

Hi! @dayongkr

When defining utility functions in the compat layer, we should follow lodash's test!

Thank you for your good comments.

The uniqueId you created was more readable, so I changed my code a bit.

And in my opinion, it is better not to verify lodash's third test code because it does not match es-toolkit's design principles.

What do you think?

Give you ref: Design Principles

[dayongkr]

Design Principles

Thank you for reviewing my opinion.

I think that seems to refer to cases where JavaScript implicitly converts types at the language level(e.g. '3' + 3 === '3' + '3'). However, the test case involves explicitly coercing a number into a string, so I think it is necessary.

[raon0211]

As @dayongkr mentioned, I think we should handle that test case.

[Na-hyunwoo]

@dayongkr @raon0211

This corresponds to implicit type conversion.

Cool.

I will reflect this and commit.

[raon0211]

Thanks for your contribution!