This repository has been archived by the owner on Oct 31, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
fix(p2p): accept listener connection during bootstrap #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #484 +/- ##
==========================================
+ Coverage 72.16% 72.22% +0.05%
==========================================
Files 218 219 +1
Lines 12734 12829 +95
==========================================
+ Hits 9190 9266 +76
- Misses 3544 3563 +19 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>
Freyskeyd
force-pushed
the
fix/listener-connection-bootstrap
branch
from
March 22, 2024 13:29
be886a4
to
1b96176
Compare
hadjiszs
approved these changes
Mar 22, 2024
Signed-off-by: Monir Hadji <hadji.szs@gmail.com>
atanmarko
reviewed
Mar 25, 2024
atanmarko
reviewed
Mar 25, 2024
dvdplm
approved these changes
Mar 25, 2024
atanmarko
approved these changes
Mar 25, 2024
Freyskeyd
force-pushed
the
fix/listener-connection-bootstrap
branch
from
March 25, 2024 11:23
835dc74
to
6b0aeaa
Compare
Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>
Freyskeyd
force-pushed
the
fix/listener-connection-bootstrap
branch
from
March 25, 2024 12:55
6b0aeaa
to
e6cb5cd
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to safely initiate the bootnodes between each other, when receiving an incoming bootnode connection during bootstrap, dial back the bootnode.
PR Checklist: