Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

fix(p2p): accept listener connection during bootstrap #484

Merged
merged 6 commits into from
Mar 25, 2024

Conversation

Freyskeyd
Copy link
Member

Description

In order to safely initiate the bootnodes between each other, when receiving an incoming bootnode connection during bootstrap, dial back the bootnode.

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>
@Freyskeyd Freyskeyd requested a review from a team as a code owner March 22, 2024 11:48
@Freyskeyd Freyskeyd requested review from atanmarko and JDawg287 March 22, 2024 11:48
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 85.33333% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 72.22%. Comparing base (5b6ddb8) to head (e6cb5cd).

Files Patch % Lines
crates/topos-p2p/src/runtime/handle_event/grpc.rs 46.87% 17 Missing ⚠️
crates/topos-p2p/src/runtime/handle_event.rs 94.59% 2 Missing ⚠️
crates/topos-p2p/src/tests/bootstrap.rs 92.85% 2 Missing ⚠️
...es/topos-p2p/src/runtime/handle_event/discovery.rs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #484      +/-   ##
==========================================
+ Coverage   72.16%   72.22%   +0.05%     
==========================================
  Files         218      219       +1     
  Lines       12734    12829      +95     
==========================================
+ Hits         9190     9266      +76     
- Misses       3544     3563      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>
@Freyskeyd Freyskeyd force-pushed the fix/listener-connection-bootstrap branch from be886a4 to 1b96176 Compare March 22, 2024 13:29
crates/topos-p2p/src/network.rs Outdated Show resolved Hide resolved
@Freyskeyd Freyskeyd force-pushed the fix/listener-connection-bootstrap branch from 835dc74 to 6b0aeaa Compare March 25, 2024 11:23
Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>
@Freyskeyd Freyskeyd force-pushed the fix/listener-connection-bootstrap branch from 6b0aeaa to e6cb5cd Compare March 25, 2024 12:55
@Freyskeyd Freyskeyd merged commit b8cd730 into main Mar 25, 2024
21 checks passed
@Freyskeyd Freyskeyd deleted the fix/listener-connection-bootstrap branch March 25, 2024 13:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants