Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development #80

Merged
merged 7 commits into from
Dec 11, 2018
Merged

Development #80

merged 7 commits into from
Dec 11, 2018

Conversation

toonarmycaptain
Copy link
Owner

Fix bug student with no score passed to chart generator.
Add copy_avatar_to_app_data func. Add file_copy function. Resolves #67.
Implement GUI dialogue for avatar selection. Resolves #79.
Add select_file_dialogue GUI using Tkinter.

Signed-off-by: David <toonarmycaptain@hotmail.com>
Signed-off-by: David <toonarmycaptain@hotmail.com>
Signed-off-by: David <toonarmycaptain@hotmail.com>
Signed-off-by: David <toonarmycaptain@hotmail.com>
Implement, pass class_name through create_classlist_data down to func.

Signed-off-by: David <toonarmycaptain@hotmail.com>
Passed with score "None" which chart generation code is unable to sort
as float and causes an error.

Signed-off-by: David <toonarmycaptain@hotmail.com>
Signed-off-by: David <toonarmycaptain@hotmail.com>
@toonarmycaptain toonarmycaptain merged commit c26d036 into master Dec 11, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 272

  • 16 of 41 (39.02%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.2%) to 68.864%

Changes Missing Coverage Covered Lines Changed/Added Lines %
dionysus_app/chart_generator/take_chart_data.py 0 2 0.0%
dionysus_app/file_functions.py 2 5 40.0%
dionysus_app/UI_functions.py 5 14 35.71%
dionysus_app/class_functions.py 9 20 45.0%
Totals Coverage Status
Change from base Build 269: -1.2%
Covered Lines: 376
Relevant Lines: 546

💛 - Coveralls

@toonarmycaptain
Copy link
Owner Author

Add tests for new code: Issues #81, #82, #83.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants