Add possibility to specify ChibiOS folder #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it makes sense, hard coded path is not useful. does |
|
Yes, ?= is better. I tested it and it seems to behave as it should. I haven't needed to touch make files before starting doing this, so I didn't know that syntax. I forgot to ask, should I update the pull request, or do you manually edit it? |
|
Could you edit this pull request so that I can merge it? |
|
never mind. Fixed at afef9b4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a the possibility of specifying the location of ChibiOS. This way keyboard projects can include it in their own projects, either as a submodule or a subtree. As the modules no longer need to be nested it would even be possible to have tmk_core as a subtree and ChibiOS as a submodule, both located as subfolders of the main keyboard root folder.
I believe this is the best we can do in order to fix the issue I raised here #6. At least with this patch only the keyboard repository contributors need to care about having compatible ChibiOS and tmk_core versions, instead of all the users.