lib: support summarization of new groups backend #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/lib/summarize now supports building summaries off of the new /app/channels. If that agent is running, it will use the new summarization logic. If it's not, it will continue on as it has.
midsum-salrux
approved these changes
Nov 20, 2023
| @@ -14,6 +14,48 @@ | |||
| [(scot %p our) term (scot %da now) spur] | |||
| :: | |||
| ++ summarize-activity | |||
| ?: .^(? %gu (scry-path %channels /$)) | |||
| summarize-activity-new-groups | |||
| summarize-activity-old-groups | |||
There was a problem hiding this comment.
NB: old-groups kind of brings graph-store era groups to mind but I don't know a better name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/lib/summarizenow supports building summaries off of the new/app/channels. If that agent is running, it will use the new summarization logic. If it's not, it will continue on as it has.Somewhat important to get this out the door ahead of the new groups backend release. If a ship uses the old version of this library while the new groups backend is installed, summarization logic may crash. In practice, this probably only affects reports for %bark. (But third-party devs using this library are encouraged to pull in this latest version also.)
Also pulls in the necessary sur file dependencies. If those change, in particular the ones including types we scry for, we may need to update the files here again. (One such change is probably on the way, we may want to hold off on merging for at least a day.)
(The
/sur/chat-2included here is a version that has been stripped of its references to/lib/graph-store. The types/functions for that aren't used in this desk, and the dependency was giving import troubles. At some point after this release cycle, we should clean up the tangled dependency situation.)LAND-1211