Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: add token-based upload for hosting #222

Merged
merged 10 commits into from
Oct 23, 2023
Merged

storage: add token-based upload for hosting #222

merged 10 commits into from
Oct 23, 2023

Conversation

guaraqe
Copy link
Contributor

@guaraqe guaraqe commented Sep 28, 2023

From @arthyn: This fixes LAND-999 by adding new state to the %storage backend and allows hosting users to customize whether they want to use Tlon provided presigned URLs or their own custom credentials for direct S3 uploads.

image image

Similar changes are being pulled into the Tlon app here: tloncorp/tlon-apps#2906

@jamesacklin
Copy link
Member

@guaraqe Thanks, looking good so far. A note: Tlon S3 hosting should only be available to Tlon Hosting customers. Anyone else should get the S3 endpoint form they see now.

@arthyn arthyn changed the title [WIP] Add token-based upload for hosting storage storage: add token-based upload for hosting Oct 18, 2023
@linear
Copy link

linear bot commented Oct 18, 2023

LAND-999 s3: UI for enabling/disabling Tlon Hosting s3 for hosted ships

Related: HOST-69, specifically this comment: HOST-69

In order to support s3 we're going create secrets urbit side that then can be provided to hosting.

nathan is working on that requirement in LAND-1000

We will also need a way for users to enable/disable Tlon Hosting s3.

The requirements:

  • We can use the remote storage settings in landscape
  • All of this appears only for Tlon Hosted ships
  • If the user has s3 already configured then by default have Tlon Hosting s3 disabled
  • If the user does not have s3 already configured then have it default enabled
  • When enabled - it does not overwrite any custom config, but separately turns on hardcoded defaults provided by hosting
  • If a user with custom s3 config attempts to enable Tlon Hosting s3, keep their custom config in the custom config settings, but enable Tlon Hosting s3. Also explain to the user what is happening. If the user then disables Tlon Hosting s3, revert back to their existing custom config.
  • When the Tlon Hosting config is enabled, this config should use a hardcoded URL provided by hosting.
  • james is working on designs for some of this, assigning to him now for handling.

Basically most users should just wake up with an OTA that gives them out of the box s3 and they'll never need to know about this settings existence. We will also handle the couple of other corner cases.

@arthyn arthyn marked this pull request as ready for review October 18, 2023 18:46
Copy link
Contributor

@midsum-salrux midsum-salrux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything re: getting and using the genuine token looks good to me.

Copy link
Member

@patosullivan patosullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@arthyn arthyn merged commit 4b7ce11 into master Oct 23, 2023
1 check passed
@arthyn arthyn deleted the add-token-upload branch October 23, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants