-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storage: add token-based upload for hosting #222
Conversation
Just to help thinking
@guaraqe Thanks, looking good so far. A note: Tlon S3 hosting should only be available to Tlon Hosting customers. Anyone else should get the S3 endpoint form they see now. |
LAND-999 s3: UI for enabling/disabling Tlon Hosting s3 for hosted ships
Related: HOST-69, specifically this comment: HOST-69 In order to support s3 we're going create secrets urbit side that then can be provided to hosting. nathan is working on that requirement in LAND-1000 We will also need a way for users to enable/disable Tlon Hosting s3. The requirements:
Basically most users should just wake up with an OTA that gives them out of the box s3 and they'll never need to know about this settings existence. We will also handle the couple of other corner cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything re: getting and using the genuine token looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
From @arthyn: This fixes LAND-999 by adding new state to the %storage backend and allows hosting users to customize whether they want to use Tlon provided presigned URLs or their own custom credentials for direct S3 uploads.
Similar changes are being pulled into the Tlon app here: tloncorp/tlon-apps#2906